Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prometheus-exporter-address option #1698

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Remove prometheus-exporter-address option #1698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugins/prometheus_plugin/include/eosio/prometheus_plugin/prometheus_plugin.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
#include <eosio/chain/application.hpp>
#include <eosio/http_plugin/http_plugin.hpp>
#include <eosio/chain_plugin/chain_plugin.hpp>
#include <eosio/producer_plugin/producer_plugin.hpp>
#include <eosio/net_plugin/net_plugin.hpp>

namespace eosio {

Expand All @@ -13,7 +15,7 @@ namespace eosio {
prometheus_plugin();
~prometheus_plugin() override;

APPBASE_PLUGIN_REQUIRES((http_plugin)(chain_plugin))
APPBASE_PLUGIN_REQUIRES((http_plugin)(chain_plugin)(producer_plugin)(net_plugin))

void set_program_options(options_description&, options_description& cfg) override;

Expand Down
5 changes: 0 additions & 5 deletions plugins/prometheus_plugin/prometheus_plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@
#include <eosio/chain/plugin_interface.hpp>
#include <eosio/chain/thread_utils.hpp>
#include <eosio/http_plugin/macros.hpp>
#include <eosio/net_plugin/net_plugin.hpp>
#include <eosio/http_plugin/http_plugin.hpp>
#include <eosio/producer_plugin/producer_plugin.hpp>

#include <fc/log/logger.hpp>

Expand Down Expand Up @@ -36,9 +34,6 @@ namespace eosio {
prometheus_plugin::~prometheus_plugin() = default;

void prometheus_plugin::set_program_options(options_description&, options_description& cfg) {
cfg.add_options()
("prometheus-exporter-address", bpo::value<string>()->default_value("127.0.0.1:9101"),
"The local IP and port to listen for incoming prometheus metrics http request.");
}

struct prometheus_api_handle {
Expand Down