avoid possible memcpy with nullptr when action data size is 0 #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
requested changes
Sep 18, 2023
Co-authored-by: Gregory Popovitch <greg7mdp@gmail.com>
greg7mdp
approved these changes
Sep 18, 2023
heifner
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When action data size is 0, it was possible for a
memcpycall to contain a source pointer ofnullptrand length of0. This is not defined behavior, but a careful analysis of leap's supported platforms and prior builds shows no evidence this could be a source of indeterminism so this change is not being treated as a security fix.