Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some additional test cases in modexp benchmark #1635

Merged
merged 2 commits into from
Sep 14, 2023
Merged

add some additional test cases in modexp benchmark #1635

merged 2 commits into from
Sep 14, 2023

Conversation

spoonincode
Copy link
Member

This adds a number of new cases in the modexp benchmark:

  • more widths (I was curious to see behavior at smaller sizes)
  • even vs odd modulus (very, very, critical performance difference for some modexp impls)
  • base being greater vs less than modulus (for some impls results in minor difference in code path taken)

@spoonincode
check that MSB of modulus is not 0
d3275c2 
otherwise B<M case may not be true by setting MSB of base to 0
@spoonincode spoonincode merged commit 85280f5 into main Sep 14, 2023
@spoonincode spoonincode deleted the moar_modexp_benchmarking branch September 14, 2023 02:55
@spoonincode spoonincode linked an issue Sep 14, 2023 that may be closed by this pull request
Migrate mod_exp to BoringSSL, removing GMP requirement #1277
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate mod_exp to BoringSSL, removing GMP requirement
3 participants
@spoonincode @heifner @linh2931