-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gcc version check in CMakeLists.txt. #1530
Conversation
@spoonincode it looks like the ubuntu 20.04 runner has gcc 10.3, which surprosed me because the package lists 10.5. Do you know how to explain this discrepancy? |
The build platforms are cached to improve CI performance; the platform cache was probably built before Ubuntu 20.04 pushed out the upgrade to 10.5. (the platform cache doesn't really help all that much for the current Ubuntu 20 & 22 environment since they do nothing more than install packages, but it can really be beneficial for something like the pinned builds or potentially other scenarios where we need to compile a whole toolchain to perform a build) To investigate this theory more, we can take a look at the sha256 of the Then we can look up that image on github,
I'm not sure how to determine when Ubuntu pushed out a particular package update? The best I could find was an acceptance of the 10.5 package on Jul 31 -- less than 22 days ago. There are a couple things you can do to repopulate the cache. One is to just make a benign modification to Either choice is fine. |
CMakeLists.txt
Outdated
@@ -37,8 +37,8 @@ set( LEAP_UTIL_EXECUTABLE_NAME leap-util ) | |||
|
|||
# http://stackoverflow.com/a/18369825 | |||
if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU") | |||
if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 9.0) | |||
message(FATAL_ERROR "GCC version must be at least 9.0!") | |||
if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 10.5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Debian 11 is still on 10.2. Do we really feel we must have 10.5 over 10.x? A bit of a shame to block out Debian 11 unless we have reason to believe we need to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably 10.2 is fine. I'll update the check for 10.2, and try the ubuntu20.Dockerfile
to regenerate!
Thanks for the thorough explanation above!
I missed this change with the C++20 switch.