Fix -Wsign-compare warnings
#1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
reviewed
Aug 2, 2023
| @@ -36,6 +36,7 @@ if("eos-vm-oc" IN_LIST EOSIO_WASM_RUNTIMES) | |||
|
|
|||
| set_source_files_properties(webassembly/runtimes/eos-vm-oc/LLVMJIT.cpp PROPERTIES COMPILE_FLAGS "--std=gnu++17") | |||
| set_source_files_properties(webassembly/runtimes/eos-vm-oc/LLVMEmitIR.cpp PROPERTIES COMPILE_FLAGS "--std=gnu++17") | |||
| set_source_files_properties(webassembly/runtimes/eos-vm-oc/switch_stack_linux.s PROPERTIES COMPILE_FLAGS "-Wno-unused-command-line-argument") | |||
There was a problem hiding this comment.
I think this is a fine fix.. but I wonder why cmake is operating this way 🤔 it clearly knows that .s are assembly files -- not c/c++ files -- so why is it tacking on all the c/c++ options like -O3 -DNDEBUG etc
heifner
approved these changes
Aug 2, 2023
| @@ -530,7 +530,7 @@ BOOST_FIXTURE_TEST_CASE(test_session_fork, state_history_test_fixture) { | |||
| std::vector<eosio::state_history::block_position> have_positions; | |||
| eosio::state_history::state_result result; | |||
| // we should get 4 consecutive block result | |||
| for (int i = 0; i < 4; ++i) { | |||
| for (uint32_t i = 0; i < 4; ++i) { | |||
There was a problem hiding this comment.
Hum, I'm not sure. The warning was when comparing with r.this_block->block_num which is a uint32_t.
If it was a comparison with <container>.size() then I would have used size_t.
There was a problem hiding this comment.
Ah, I thought it was likely complaining about the written_data[i]. uint32_t then.
| @@ -580,7 +580,7 @@ BOOST_FIXTURE_TEST_CASE(test_session_fork, state_history_test_fixture) { | |||
|
|
|||
| eosio::state_history::state_result fork_result; | |||
| // we should now get data for fork 3,4 | |||
| for (int i = 2; i < 4; ++i) { | |||
| for (uint32_t i = 2; i < 4; ++i) { | |||
linh2931
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.