[4.0 -> main] Modify trace_api_plugin to report serialization errors to user #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime to deserialize
[3.2] Modify trace_api_plugin to report serialization errors to user
[3.2 -> 4.0] Modify trace_api_plugin to report serialization errors to user
greg7mdp
approved these changes
Jul 31, 2023
tests/trace_plugin_test.py
Outdated
Comment on lines
101
to
102
| Utils.Print("Ignore expected: ERROR: Node relaunch Failed") | ||
| isRelaunchSuccess = node.relaunch(timeout=10, addSwapFlags={"--http-max-response-time-ms": "0", "--abi-serializer-max-time-ms": "0"}) |
There was a problem hiding this comment.
Will the relaunch fail as the message indicates?
Also wondering if it is useful to assign to isRelaunchSuccess?
There was a problem hiding this comment.
get_info can't fail in main, so it actually does work. I'll update the test.
greg7mdp
reviewed
Jul 31, 2023
tests/plugin_http_api_test.py
Outdated
| # get_transaction_trace with invalid parameter | ||
| ret_json = self.nodeos.processUrllibRequest(resource, command, self.http_post_invalid_param) | ||
| self.assertEqual(ret_json["code"], 400) | ||
| # get_transaction_trace with valid parameter |
There was a problem hiding this comment.
Suggested change
| # get_transaction_trace with valid parameter | |
| # get_transaction_trace with syntactically correct parameter, but random id, so should return 404 (not found) |
greg7mdp
approved these changes
Jul 31, 2023
dimas1185
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges
release/4.0intomainincluding #1449 & #1468.The 3.1 & 3.2 version of this PR would send the deadline exception to the user so that they know they hit a deadline. In
mainthere is no longer a deadline enforced fortrace_api_pluginserialization since it is all processed off the main thread. We still report any exceptions to the user if they would happen to hit some kind of serialization error. Alsotrace_plugin_test.pyhas been updated to expect success even when configured with zero time forhttp-max-response-time-msandabi-serializer-max-time-ms.Resolves #1433