[4.0 -> main] Ignore http error on remote_endpoint() causing terminate #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[3.2] Ignore http error on remote_endpoint() causing terminate
[3.2 -> 4.0] Ignore http error on remote_endpoint() causing terminate
greg7mdp
approved these changes
Jul 26, 2023
linh2931
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remote_endpoint()call was generating errorTransport endpoint is not connected. This call is only used for logging of the remote endpoint. Ignore the error and logunknownfor the remote endpoint. This prevents an uncaught exception in 3.2 and an exit of the http thread pool in 4.0+.Already fixed in 4.0+ via: #1175
Merges
release/4.0intomainincluding #1452 & #1453. No diff as fix already in main via #1177.Resolves #1418