[3.2] Log block trx summary for speculative and BP blocks #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roduced and speculative blocks
…ccessful trx #/time.
spoonincode
reviewed
Sep 14, 2022
| @@ -226,6 +249,12 @@ class account_failures { | |||
|
|
|||
| std::map<account_name, account_failure> failed_accounts; | |||
| uint32_t max_failures_per_account = 3; | |||
| mutable fc::microseconds block_idle_time; | |||
There was a problem hiding this comment.
Quite unusual to see this. How bad is it to unwind the const train to not make this mutable? A cursory look, seems like report() const is called from both abort_block() & produce_block() (neither of which are const already)
There was a problem hiding this comment.
Thanks. Removed mutable/const which is much cleaner.
spoonincode
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional logging to report transaction execution time per block including speculative blocks. Also report block idle time waiting on incoming transactions.
The output is enabled by
producer_pluginlogger atdebuglevel.Example output:
Block trx idle:is time the node is waiting for trxs to come into a node and be scheduled for execution since the end of the last trx processed.out ofis the time since the last block completion. Should be close to the configured CPU Effort for a given block. For example an empty block with 80% CPU effortBlock trx idle: 400351us out of 400541us, success: 0, 0us, fail: 0, 0us, other: 190us. The complete "idle" time for this block would be 500ms. The idle time of the CPU effort is not reported. The value should be thought of as the time the node was able according to configuration to process trxs.success: {n}, {t}usis the number of successful transactions processed during this block and how long they took to execute.fail: {n}, {t}usis the number of transactions that failed processing during this block and how long they took to execute before they failed.other:is the time of (out of-Block trx idle-success time-fail time). The time nodeos is logging or doing other book keeping. It is the block time not accounted for in the other reported times.Also move
producer_plugin.cpp:1980 push_transaction ] Failed 3050003 trx, auth: stopblocking, prev billed: 0us, ran: 5594us, id: b9cb28694b54e721994011e4d4ae128dee54467a98e8afb3e7b9d6d041fe2f91logging totransaction_failure_tracinglogger fromproducer_pluginas it produces too much logging whenproducer_pluginset todebug.Resolves #119