[4.0 -> main] Fix incorrect serializing of std::optional when value is not provided - (GH #1189) #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Jul 5, 2023
unittests/abi_tests.cpp
Outdated
| static fc::time_point get_deadline() { | ||
| if (max_serialization_time == fc::microseconds::maximum()) | ||
| return fc::time_point(fc::microseconds::maximum()); | ||
| return fc::time_point::now() + max_serialization_time; |
There was a problem hiding this comment.
Thanks. I also did a small cleanup in safe_add()
heifner
approved these changes
Jul 5, 2023
linh2931
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1189 .
When serializing a std::optional field, and a value is not provided for the std::optional, we need to add into the serialization the flag specifying that a missing value is serialized. Prior to this PR, the flag was missing.