Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0 -> main] P2P: fix head_num reporting #1347

Merged
merged 4 commits into from
Jun 29, 2023
Merged

[4.0 -> main] P2P: fix head_num reporting #1347

merged 4 commits into from
Jun 29, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Jun 28, 2023

P2P notice_message.known_trx catch_up does not report head_num, so do not update head_num reporting. none message does. Regardless only update head_num if a valid value.

Merges release/4.0 into main including #1345

Resolves #1328

@heifner heifner requested review from linh2931 and dimas1185 June 28, 2023 11:12
@heifner heifner added the OCI Work exclusive to OCI team label Jun 28, 2023
@heifner heifner merged commit 24f2511 into main Jun 29, 2023
@heifner heifner deleted the GH-1328-p2p-main branch June 29, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimas1185 dimas1185 dimas1185 approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4.0.2: cleos net peers shows incorrect head_num
3 participants
@heifner @dimas1185 @linh2931