[4.0 -> main] Pinned Builds manual dispatch workflow in CI #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed quickly allowing development of actual workflow in follow on branch. Need to have workflow file merged before github will allow triggering it in a development branch.
Build package and upload artifacts.
… for easier removal in future.
Ubuntu 18.04 installs git 2.17.1, but need 2.18+ for git submodules to work.
…epository to work.
…x grep and store in env variable.
…rtifact name correctly.
…knob [3.1] `CMAKE_INSTALL_PREFIX=/usr` for pinned builds in CI
[3.1] Pinned Builds manual dispatch workflow in CI
…-3.2 [3.1 -> 3.2] Pinned Builds manual dispatch workflow in CI
…-4.0 [3.2 -> 4.0] Pinned Builds manual dispatch workflow in CI
heifner
reviewed
Jun 23, 2023
.github/workflows/pinned_build.yaml
Outdated
| matrix: | ||
| platform: [ubuntu18, ubuntu20, ubuntu22] | ||
| runs-on: ["self-hosted", "enf-x86-beefy-long"] | ||
| container: ${{ matrix.platform == 'ubuntu18' && 'ubuntu:bionic' || matrix.platform == 'ubuntu20' && 'ubuntu:focal' || 'ubuntu:jammy' }} |
There was a problem hiding this comment.
Do we need th ubuntu18 stuff for 4.0?
There was a problem hiding this comment.
Good call. Thanks for catching that. Addressed: 933c550
heifner
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinned builds run in GitHub Actions
Resolves: #735