[4.0] SHiP: fix intermittent empty get_block_result #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larryk85
approved these changes
Jun 13, 2023
greg7mdp
approved these changes
Jun 13, 2023
This was referenced Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use provided
block_stateonstate_history_pluginsend_updatesinceforkdbmay not have the block marked as validated yet and therefore will not be found bystate_history_pluginwhen searching by block number.See #1275 for details on why
forkdbdoes not always "contain" the block.Updated
nodeos_forked_chain_test.pyto use SHiP since it easily reproduced this failure.Resolves #1272