Cleanup pimpl idiom for net_plugin
#1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, for the pimpl idiom, the implementation resides in the private class, in our case
net_plugin_impl.Before this change,
plugin_initializeandplugin_startupwere defined innet_plugin, dereferencing members fromnet_plugin_implthrough themypointer.This PR does not change what the code does, it should be 100% equivalent to what was there before (besides
handle_sigup()being out of the try/catch block which I believe is inconsequential), however it moves the two member functions implementation within thenet_plugin_implclass.Also cleaned up
connection::_close()which doesn't need to be static.