Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2P use round trip of time_message to calculate latency #1235

Closed
wants to merge 8 commits into from

Conversation

heifner
Copy link
Member

@heifner heifner commented Jun 6, 2023

Address peer review comment: #1215 (comment)

Use round trip time for time_message which was already implemented. Since this already did a round trip for previous versions of P2P, no new P2P protocol version is needed. All that was needed was to add the calculation and normalize epoch time. Previous versions of leap did not specify duration resolution of time_since_epoch. Some clients returned microsecond values and others returned nanosecond values. Included in this PR is a fix so that all nodeos going forward will return nanosecond values even if the resolution is only microseconds.

Resolves #1072

@heifner heifner requested review from greg7mdp and vladtr June 6, 2023 15:51
@heifner heifner added the OCI Work exclusive to OCI team label Jun 6, 2023
@greg7mdp
Copy link
Contributor

greg7mdp commented Jun 6, 2023

Kevin, could you improve the comments on these?

      tstamp                         org{0};          //!< originate timestamp
      tstamp                         rec{0};          //!< receive timestamp
      tstamp                         dst{0};          //!< destination timestamp
      tstamp                         xmt{0};          //!< transmit timestamp

@heifner heifner marked this pull request as draft June 7, 2023 16:36
@heifner heifner marked this pull request as ready for review June 7, 2023 16:36
@heifner
Copy link
Member Author

heifner commented Jun 7, 2023

Replaced by #1243. Github somehow became out of sync with this branch. Pushing to the branch did nothing.

@heifner heifner closed this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P2P Improve sync behavior
3 participants