P2P use round trip of time_message to calculate latency #1235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address peer review comment: #1215 (comment)
Use round trip time for
time_message
which was already implemented. Since this already did a round trip for previous versions of P2P, no new P2P protocol version is needed. All that was needed was to add the calculation and normalize epoch time. Previous versions ofleap
did not specify duration resolution oftime_since_epoch
. Some clients returned microsecond values and others returned nanosecond values. Included in this PR is a fix so that allnodeos
going forward will return nanosecond values even if the resolution is only microseconds.Resolves #1072