[PH] Read-Only transaction support #1229

oschwaldp-oci · 2023-06-05T15:24:55Z

Mode Support: API Node (HTTP Node)
- Create support for read-only transactions in the http transaction generator
- Use existing "payloadless" test contract with read-only action defined
New config options
- --api-nodes-read-only-threads - "API nodes read only threads count for use with read-only transactions", default=0
- api-endpoint -- "The api endpoint to direct transactions to. Defaults to: '/v1/chain/send_transaction2'" (Specified in the user-trx-data-file)
Add performance load test with read-only trxs

Resolves: #783

…pcoming additions including specifying actual api endpoints for use.

Previously it was leaving the empty placeholder in the map which made it trigger the map as non empty and do unnecessary work in the generator.

…nfig. Add configuration option for api-endpoint to allow targeting specific http endpoint with transactions. Configurable number of read-only threads for the api nodes. Allow for empty authorizations in transaction action for read-only trx support.

Add apiEndpoint and userTrxData to test report for reference. Simplify createReport argument list.

…ctionGeneratorsLauncher itself.

tests/trx_generator/trx_provider.hpp

tests/trx_generator/trx_provider.cpp

tests/trx_generator/trx_provider.hpp

… files. Address possibility of optional receipt not having data if a transaction fails.

tests/trx_generator/trx_provider.cpp

tests/trx_generator/trx_provider.hpp

linh2931

In addition to read-only trxs, we run read-only Chain APIs like get_info, get_block, ... on the read-only threads. It would be nice to have a performance test of mixture of them. But that can be a separate task.

linh2931 · 2023-06-06T18:50:02Z

tests/TestHarness/launch_transaction_generators.py

-                                                        In \"p2p\" mode transactions will be directed to the p2p endpoint on a producer node. \
-                                                        In \"http\" mode transactions will be directed to the http endpoint on an api node.",
-                                                        choices=["p2p", "http"], default="p2p")
+    parser.add_argument("endpoint_api_type", type=str, help="Endpoint API mode (\"p2p\", \"http\"). \


I think API here is confusing. Why not just Endpoint mode?

Addressed: a8f559c

linh2931 · 2023-06-06T18:55:27Z

tests/performance_tests/CMakeLists.txt

@@ -15,21 +16,25 @@ endif()

 add_test(NAME performance_test_bp COMMAND tests/performance_tests/performance_test.py testBpOpMode --max-tps-to-test 50 --test-iteration-min-step 10 --test-iteration-duration-sec 10 --final-iterations-duration-sec 10 --calc-chain-threads lmax overrideBasicTestConfig -v --tps-limit-per-generator 25 --chain-state-db-size-mb 200 ${UNSHARE} WORKING_DIRECTORY ${CMAKE_BINARY_DIR})
 add_test(NAME performance_test_api COMMAND tests/performance_tests/performance_test.py testApiOpMode --max-tps-to-test 50 --test-iteration-min-step 10 --test-iteration-duration-sec 10 --final-iterations-duration-sec 10 --calc-chain-threads lmax overrideBasicTestConfig -v --tps-limit-per-generator 25 --chain-state-db-size-mb 200 ${UNSHARE} WORKING_DIRECTORY ${CMAKE_BINARY_DIR})
+add_test(NAME performance_test_ro COMMAND tests/performance_tests/performance_test.py testApiOpMode --max-tps-to-test 50 --test-iteration-min-step 10 --test-iteration-duration-sec 10 --final-iterations-duration-sec 10 overrideBasicTestConfig -v --tps-limit-per-generator 25 --api-nodes-read-only-threads 2 --account-name "payloadless" --abi-file payloadless.abi --wasm-file payloadless.wasm --contract-dir unittests/test-contracts/payloadless --user-trx-data-file tests/performance_tests/readOnlyTrxData.json --chain-state-db-size-mb 200 ${UNSHARE} WORKING_DIRECTORY ${CMAKE_BINARY_DIR})


You can expand the name performance_test_ro to performance_test_read_only_trxs

Addressed: a8f559c

linh2931 · 2023-06-06T18:56:18Z

tests/performance_tests/CMakeLists.txt

 add_test(NAME performance_test_basic_ex_transfer_trx_spec COMMAND tests/performance_tests/performance_test_basic.py -v --producer-nodes 1 --validation-nodes 1 --target-tps 20 --tps-limit-per-generator 10 --test-duration-sec 5 --chain-state-db-size-mb 200 --user-trx-data-file tests/performance_tests/userTrxDataTransfer.json ${UNSHARE} WORKING_DIRECTORY ${CMAKE_BINARY_DIR})
 add_test(NAME performance_test_basic_ex_new_acct_trx_spec COMMAND tests/performance_tests/performance_test_basic.py -v --producer-nodes 1 --validation-nodes 1 --target-tps 20 --tps-limit-per-generator 10 --test-duration-sec 5 --chain-state-db-size-mb 200 --user-trx-data-file tests/performance_tests/userTrxDataNewAccount.json ${UNSHARE} WORKING_DIRECTORY ${CMAKE_BINARY_DIR})
 add_test(NAME performance_test_basic_ex_cpu_trx_spec COMMAND tests/performance_tests/performance_test_basic.py -v --producer-nodes 1 --validation-nodes 1 --target-tps 20 --tps-limit-per-generator 10 --test-duration-sec 5 --chain-state-db-size-mb 200 --account-name "c" --abi-file eosmechanics.abi --wasm-file eosmechanics.wasm --contract-dir unittests/contracts/eosio.mechanics --user-trx-data-file tests/performance_tests/cpuTrxData.json ${UNSHARE} WORKING_DIRECTORY ${CMAKE_BINARY_DIR})
 add_test(NAME performance_test_basic_ex_ram_trx_spec COMMAND tests/performance_tests/performance_test_basic.py -v --producer-nodes 1 --validation-nodes 1 --target-tps 20 --tps-limit-per-generator 10 --test-duration-sec 5 --chain-state-db-size-mb 200 --account-name "r" --abi-file eosmechanics.abi --wasm-file eosmechanics.wasm --contract-dir unittests/contracts/eosio.mechanics --user-trx-data-file tests/performance_tests/ramTrxData.json ${UNSHARE} WORKING_DIRECTORY ${CMAKE_BINARY_DIR})
+add_test(NAME performance_test_basic_ex_read_only_trxs COMMAND tests/performance_tests/performance_test_basic.py -v --endpoint-api-type http --producer-nodes 1 --validation-nodes 1 --api-nodes 1 --api-nodes-read-only-threads 2 --target-tps 20 --tps-limit-per-generator 10 --test-duration-sec 5 --chain-state-db-size-mb 200 --account-name "payloadless" --abi-file payloadless.abi --wasm-file payloadless.wasm --contract-dir unittests/test-contracts/payloadless --user-trx-data-file tests/performance_tests/readOnlyTrxData.json ${UNSHARE} WORKING_DIRECTORY ${CMAKE_BINARY_DIR})


What does ex mean here?

Honestly, it's been long enough I can't remember if it was example or execute. Regardless, could probably be removed and just have, for instance, performance_test_basic_read_only_trxs.

Addressed: a8f559c

Rename and simplify test naming for clarity. Rename endpoint api type to simply be endpoint mode for clarity.

oschwaldp-oci added 8 commits June 2, 2023 12:59

Rename to include 'type' for the endpoint api to differentiate with u…

3902a9e

…pcoming additions including specifying actual api endpoints for use.

Erase map entry if resulting locate of key words turns up empty.

1da6a83

Previously it was leaving the empty placeholder in the map which made it trigger the map as non empty and do unnecessary work in the generator.

Merge branch 'main' into ph-read-only-trxs

bec972a

Forgot to add test to group.

b803af6

Add performance load test with read-only trxs

a41b2ff

Add apiEndpoint and userTrxData to test report for reference. Simplify createReport argument list.

Refactor endpointApiType and apiEndpoint a little.

f7f487d

Fix endpointApiType which moved from TpsTrxGensConfig onto the Transa…

ed5333b

…ctionGeneratorsLauncher itself.

oschwaldp-oci requested a review from heifner June 5, 2023 18:47

heifner added the OCI Work exclusive to OCI team label Jun 5, 2023

oschwaldp-oci added 2 commits June 5, 2023 14:52

Make configuration of validation and api nodes condititional.

edd768b

Update documentation.

265ae7f

heifner requested changes Jun 5, 2023

View reviewed changes

oschwaldp-oci added 3 commits June 5, 2023 15:25

Address peer review comments.

f9838a1

Merge branch 'main' into ph-read-only-trxs

f16786e

Address peer review comments & move function implementations into cpp…

566e12f

… files. Address possibility of optional receipt not having data if a transaction fails.

heifner reviewed Jun 6, 2023

View reviewed changes

tests/trx_generator/trx_provider.cpp Show resolved Hide resolved

heifner reviewed Jun 6, 2023

View reviewed changes

tests/trx_generator/trx_provider.cpp Outdated Show resolved Hide resolved

heifner reviewed Jun 6, 2023

View reviewed changes

tests/trx_generator/trx_provider.hpp Outdated Show resolved Hide resolved

heifner reviewed Jun 6, 2023

View reviewed changes

tests/trx_generator/trx_provider.hpp Outdated Show resolved Hide resolved

oschwaldp-oci added 2 commits June 6, 2023 09:33

Another round of peer review comments addressed.

776040a

Merge branch 'main' into ph-read-only-trxs

ff2d795

heifner approved these changes Jun 6, 2023

View reviewed changes

oschwaldp-oci requested review from ScottBailey and linh2931 and removed request for ScottBailey June 6, 2023 15:27

Merge branch 'main' into ph-read-only-trxs

85ea6ff

linh2931 reviewed Jun 6, 2023

View reviewed changes

Address peer review comments.

a8f559c

Rename and simplify test naming for clarity. Rename endpoint api type to simply be endpoint mode for clarity.

linh2931 approved these changes Jun 6, 2023

View reviewed changes

oschwaldp-oci merged commit 6ad3081 into main Jun 6, 2023

oschwaldp-oci deleted the ph-read-only-trxs branch June 6, 2023 21:25

linh2931 restored the ph-read-only-trxs branch September 14, 2023 01:09

linh2931 mentioned this pull request Sep 14, 2023

Investigate Max Throughput for Read Only Transactions #1634

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PH] Read-Only transaction support #1229

[PH] Read-Only transaction support #1229

oschwaldp-oci commented Jun 5, 2023 •

edited

Loading

linh2931 left a comment

linh2931 Jun 6, 2023

oschwaldp-oci Jun 6, 2023

linh2931 Jun 6, 2023

oschwaldp-oci Jun 6, 2023

linh2931 Jun 6, 2023

oschwaldp-oci Jun 6, 2023

oschwaldp-oci Jun 6, 2023

[PH] Read-Only transaction support #1229

[PH] Read-Only transaction support #1229

Conversation

oschwaldp-oci commented Jun 5, 2023 • edited Loading

linh2931 left a comment

Choose a reason for hiding this comment

linh2931 Jun 6, 2023

Choose a reason for hiding this comment

oschwaldp-oci Jun 6, 2023

Choose a reason for hiding this comment

linh2931 Jun 6, 2023

Choose a reason for hiding this comment

oschwaldp-oci Jun 6, 2023

Choose a reason for hiding this comment

linh2931 Jun 6, 2023

Choose a reason for hiding this comment

oschwaldp-oci Jun 6, 2023

Choose a reason for hiding this comment

oschwaldp-oci Jun 6, 2023

Choose a reason for hiding this comment

oschwaldp-oci commented Jun 5, 2023 •

edited

Loading