Extended snapshot scheduler to better handle missing and zero params #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
requested changes
Jun 1, 2023
heifner
reviewed
Jun 2, 2023
spoonincode
reviewed
Jun 2, 2023
| snapshot_request_params sri2 = {.block_spacing = 5000, .start_block_num = 100000, .end_block_num = 300000, .snapshot_description = "Example of recurring snapshot 2 that will never happen"}; | ||
| snapshot_request_params sri3 = {.block_spacing = 2, .start_block_num = 0, .end_block_num = 3, .snapshot_description = "Example of recurring snapshot 3 that will expire"}; | ||
| snapshot_request_params sri4 = {.start_block_num = 1, .snapshot_description = "One time snapshot on first block"}; | ||
| snapshot_request_params sri5 = {.block_spacing = 10, .snapshot_description = "Recurring every 10 blocks snapshot starting now"}; |
There was a problem hiding this comment.
I don't see any new unit tests; do we need to add any more tests to expressly cover the example given in #1152? For example, head block is 6, and then a new request to .block_spacing = 10, .start_block_num = 0, .end_block_num = 0 is made, and then we should have snapshots on blocks 10 & 20, for example.
There was a problem hiding this comment.
Thank you, done! Extended tests to run a little longer and check for timings on first 2 snapshots
greg7mdp
reviewed
Jun 2, 2023
greg7mdp
approved these changes
Jun 2, 2023
heifner
approved these changes
Jun 5, 2023
This was referenced Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add differentiation between missing and zero-valued parameters in api request for start, end and spacing of blocks, in particular, as it was observed in original issue making start_block_num assignable to "0" in request or directly in snapshot-schedule.json file, such as:
{ "snapshot_requests": [ { "snapshot_request_id": "0", "snapshot_description": "Hourly snapshots starting from genesis", "block_spacing": "7200", "start_block_num": "0", "end_block_num": "0" } ] }Prior implementation treated zero start as missing value and replaced it with "now" block num
Resolves #1152