refactor listener #1218
Merged
refactor listener #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @huangminghuang for your personal contribution. It is very much appreciated. |
heifner
approved these changes
May 30, 2023
greg7mdp
requested changes
May 31, 2023
This comment was marked as resolved.
This comment was marked as resolved.
spoonincode
reviewed
Jun 2, 2023
| auto endpoints = resolver.resolve(host, port, tcp::resolver::passive, ec); | ||
| if (ec) { | ||
| fc_elog(logger, "failed to resolve address: ${msg}", ("msg", ec.message())); | ||
| throw std::system_error(ec); |
There was a problem hiding this comment.
Is there a reason to use this if/fc_elog/throw combo for these over a single EOS_ASSERT line?
There was a problem hiding this comment.
EOS_ASSERT is defined in chain, while this function is defined in fc.
greg7mdp
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
fc::listenerto simply its usage by using lambda instead of inheritance for customization.