-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup producer_plugin pimpl idiom. #1213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
requested changes
May 26, 2023
heifner
reviewed
May 26, 2023
heifner
reviewed
May 26, 2023
heifner
reviewed
May 26, 2023
heifner
reviewed
May 26, 2023
heifner
reviewed
May 26, 2023
heifner
reviewed
May 26, 2023
heifner
reviewed
May 26, 2023
heifner
reviewed
May 26, 2023
heifner
reviewed
May 26, 2023
heifner
reviewed
May 26, 2023
heifner
reviewed
May 26, 2023
heifner
reviewed
May 26, 2023
heifner
reviewed
May 26, 2023
heifner
reviewed
May 26, 2023
heifner
reviewed
May 26, 2023
heifner
requested changes
May 26, 2023
heifner
reviewed
May 26, 2023
heifner
reviewed
May 26, 2023
heifner
reviewed
May 26, 2023
heifner
reviewed
May 26, 2023
heifner
approved these changes
May 26, 2023
vladtr
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, for the pimpl idiom, the implementation resides in the
private
class, in our caseproducer_plugin_impl
.Before this change, many functions were defined in
producer_plugin
, directly accessing fields fromproducer_plugin_impl
via themy
pointer.This PR does not change what the code does, it should be 100% equivalent to what was there before, however it moves most of the member functions implementation within the
producer_plugin_impl
class.I wouldn't mind doing a even fuller cleanup, so that all the
producer_plugin
methods forward toproducer_plugin_impl
and are grouped together at the bottom of the file, but it might make the change even harder to follow. Please let me know what you think.PS: most of the changes are
white space
changes, to make formatting consistent within this file. You make benefit from appending?w=1
to the diff window url to limit whitespace differences.