fix unstable gelf test #1180
Merged
fix unstable gelf test #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh2931
approved these changes
May 17, 2023
ScottBailey
reviewed
May 18, 2023
tests/gelf_test.py
Outdated
| assert received_log in stderr_line, "received GELF log entry does not match that of from stderr" | ||
| assert len(received_logs) > 10, "Not enough gelf logs are received" | ||
| for received_log in received_logs: | ||
| assert received_log in stderr_txt, "received GELF log entry does not match that of from stderr" |
There was a problem hiding this comment.
Suggested change
| assert received_log in stderr_txt, "received GELF log entry does not match that of from stderr" | |
| assert received_log in stderr_txt, "received GELF log entry does not match that of stderr" |
ScottBailey
suggested changes
May 18, 2023
ScottBailey
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the stableness of gelf test because UDP packets can be lossy even in localhost.
Resolves #1179