Keep subprocess_results.log around when test fails
#1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…but attr was already set. Allows for cases where Cluster cleanup is called initially in tests to remove old test data, which should no longer be a problem, however in doing so it now deletes subprocess_results.log while attr for checkOutputFile has already been set. This allows reopening/recreating the file and continuing to log to it to capture all commands after the initial cleanup.
heifner
approved these changes
May 11, 2023
subprocess_results.log around when test fails
jgiszczak
approved these changes
May 11, 2023
ScottBailey
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen
checkOutputFilename(subprocess_results.log) in case where file may have been deleted, but attr was already set.Allows for cases where
Cluster.cleanupis called initially in tests to remove old test data, which should no longer be a problem, however in doing so it now deletessubprocess_results.logwhile attr forcheckOutputFilehas already been set. This allows reopening/recreating the file and continuing to log to it to capture all commands after the initial cleanup.