Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gelf test #1145

Merged
merged 5 commits into from
May 15, 2023
Merged

add gelf test #1145

merged 5 commits into from
May 15, 2023

Conversation

huangminghuang
Copy link
Contributor

This PR add an integration test for GELF logging appender.

Resolves IS #1021

@huangminghuang huangminghuang requested a review from heifner May 8, 2023 20:48
@heifner heifner added the OCI Work exclusive to OCI team label May 8, 2023
@heifner heifner added this to the Leap v5.0.0-rc1 milestone May 8, 2023
@heifner heifner linked an issue May 9, 2023 that may be closed by this pull request
@BenjaminGormanPMP BenjaminGormanPMP requested a review from linh2931 May 9, 2023 21:07
tests/gelf_test.py Outdated Show resolved Hide resolved
tests/gelf_test.py Outdated Show resolved Hide resolved
tests/gelf_test.py Outdated Show resolved Hide resolved
tests/gelf_test.py Outdated Show resolved Hide resolved
@spoonincode
Copy link
Member

would we want this test to be able to run unshared, so it can eventually be out of NP tests?

@huangminghuang huangminghuang merged commit 90a519f into main May 15, 2023
@huangminghuang huangminghuang deleted the huangminghuang/gelf-test branch May 15, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration test for GELF logging
5 participants