Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0 -> main] Check read-only trx options only when read-only-thread enabled, and present better error message #1134

Merged
merged 7 commits into from
May 4, 2023
Merged

[4.0 -> main] Check read-only trx options only when read-only-thread enabled, and present better error message #1134

merged 7 commits into from
May 4, 2023

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented May 4, 2023

Merge #1129

  • Currently read-only trx options are checked even if --read-only-thread is 0. Changed to validate them only when --read-only-thread is greater than 0.
  • Current error message for invalid -read-only-read-window-time-us is confusing. Changed to use the same time unit and better error explanation. A sample looks like
warn  2023-05-04T17:08:06.246 thread-0  producer_plugin.cpp:1221  plugin_initialize    ] 3110006 plugin_config_exception: Incorrect plugin configuration   read-only-read-window-time-us (20000 us) must be greater than max-transaction-time (10000 us) plus 10000 us, required: 20000 us > (10000 us + 10000 us).
  • Reword read-only trx logging messages from the user perspective

Resolved #1088

linh2931 and others added 7 commits May 3, 2023 20:58
@linh2931 linh2931 requested review from greg7mdp and heifner May 4, 2023 17:11
@linh2931 linh2931 merged commit 31ae4cb into main May 4, 2023
@linh2931 linh2931 deleted the read_only_trx_config_fix_main branch May 4, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@heifner heifner heifner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing read-only-read-window-time-us error message
3 participants
@linh2931 @greg7mdp @heifner