Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: misc cleanup #1112

Merged
merged 5 commits into from
May 1, 2023
Merged

Tests: misc cleanup #1112

merged 5 commits into from
May 1, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented May 1, 2023

  • Remove unused NON_VALIDATING_TEST macro.
  • Add operator<< for setup_policy so setup_policy can be used with boost data in tests.
  • Allow the setup_policy to be provided to validating_tester instead of being hard-coded to full.
  • Update wasm tests to use validating_tester with different setup_policy.

Resolves #259

@heifner heifner added this to the Leap v5.0.0-rc1 milestone May 1, 2023
@heifner heifner added the OCI Work exclusive to OCI team label May 1, 2023
@heifner heifner requested review from greg7mdp and linh2931 May 1, 2023 14:51
@greg7mdp
Copy link
Contributor

greg7mdp commented May 1, 2023 •
edited
Loading

There are many tests that still use it. I believe it is useful outside of validating_tester.

Yes, just saw that. Would be nice to have only one and name it tester because validating_tester is a mouthful :-).
Maybe in the future.

@heifner
Copy link
Member Author

heifner commented May 1, 2023

Do we still use the regular tester anywhere?

There are many tests that still use it. I believe it is useful outside of validating_tester.

@heifner heifner merged commit 324ff33 into main May 1, 2023
@heifner heifner deleted the GH-259-test-cleanup branch May 1, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
Leap v5.0.0-rc1
Development

Successfully merging this pull request may close these issues.

Use github issue instead of #warning directive in wasm_tests.cpp
3 participants
@heifner @greg7mdp @linh2931