Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization: New escape_str function for sanitizing strings #1108

Merged
merged 8 commits into from
Apr 28, 2023
Merged

Optimization: New escape_str function for sanitizing strings #1108

merged 8 commits into from
Apr 28, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Apr 28, 2023

Create a new escape_str function for use of sanitizing strings without having to use format_string with its overhead of mutable_variant_object.
Also optimize print_debug used for contract console output.

Resolves #641

@heifner heifner requested review from greg7mdp and linh2931 April 28, 2023 14:41
@heifner heifner added the OCI Work exclusive to OCI team label Apr 28, 2023
@heifner heifner added this to the Leap v5.0.0-rc1 milestone Apr 28, 2023
@heifner heifner linked an issue Apr 28, 2023 that may be closed by this pull request
clean function for escaping control characters in a string and truncating it #641
Closed
linh2931
linh2931 reviewed Apr 28, 2023
View reviewed changes
libraries/chain/apply_context.cpp Show resolved Hide resolved
libraries/libfc/src/string.cpp Outdated Show resolved Hide resolved
libraries/libfc/include/fc/string.hpp Outdated Show resolved Hide resolved
greg7mdp
greg7mdp reviewed Apr 28, 2023
View reviewed changes
libraries/libfc/src/string.cpp Outdated Show resolved Hide resolved
libraries/libfc/src/string.cpp Show resolved Hide resolved
libraries/libfc/src/string.cpp Show resolved Hide resolved
Base automatically changed from GH-641-libfc-tests to main April 28, 2023 18:25
@heifner heifner merged commit 57d5546 into main Apr 28, 2023
@heifner heifner deleted the GH-641-escape-opt branch April 28, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
Leap v5.0.0-rc1
Development

Successfully merging this pull request may close these issues.

clean function for escaping control characters in a string and truncating it
3 participants
@heifner @greg7mdp @linh2931