Changes for building with c++20. #1070
Conversation
With these changes, plus the ones in the PRs opened in the following submodules: - bn256 - eos-vm - CLI11 - abieos Leap builds with clang-16 in c++20 mode.
libraries/chain/include/eosio/chain/unapplied_transaction_queue.hpp
Outdated
Show resolved
Hide resolved
|
It seems gcc12 is failing with a problem in LLVM's headers |
Yes, that is correct, that is the one issue I wasn't able to fix yet. That is why I wrote that it builds with clang-16. I did fix some other issues with gcc-12, but I was stumped on that one. I actually was thinking of asking you (once this was the last issue) to see if you had an idea, since you understand what is done there much better than I do, but otherwise I'll keep looking at it. BTW, gcc-12 is building fine in c++17 mode (and this PR does not update the flag). When flipping the flag to c++20, there is one remaining issue with gcc-12. So merging this PR would not cause any regression. |
|
@spoonincode @linh2931 @arhag @larryk85 can I get a second approval on this? Thanks! |
With these changes, plus the ones in the PRs opened in the following submodules:
Leap builds with clang-16 in c++20 mode.