Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1 -> main] Fix test failure due to trx hitting near end of block production time #107

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

heifner
Copy link
Member

@heifner heifner commented Sep 6, 2022

It is possible for a trx to arrive at the BP node a few milliseconds before block signing which results in an almost immediate inclusion in the block. The test was not expecting the trx to make it to a block so quickly.

Resolves #105
Resolves eosnetworkfoundation/mandel#488

…uickly by hitting the end of a block production window.
[3.1] Fix test failure due to trx hitting near end of block production time
@heifner heifner merged commit 9a6bb11 into main Sep 6, 2022
@heifner heifner deleted the GH-105-finality-test branch September 6, 2022 19:11
@heifner heifner added the OCI Work exclusive to OCI team label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate trx_finality_status_test failure trx_finality_status_test failed in merge build to main branch
2 participants