Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Contracts Source Files #54

Closed
oschwaldp-oci opened this issue Aug 25, 2022 · 3 comments · Fixed by #612
Closed

Test Contracts Source Files #54

oschwaldp-oci opened this issue Aug 25, 2022 · 3 comments · Fixed by #612
Assignees
Labels
👍 lgtm OCI Work exclusive to OCI team

Comments

@oschwaldp-oci
Copy link
Contributor

There are a handful of test contracts in unittests/contracts that are not accompanied by source files for easy indication of versioning or reproduction. Especially with eos-system-contracts living outside the AntelopIO organization, would it be helpful to bring the source across for reference?

They should be clearly marked as example contracts for testing and not for production use and should live in the unittests/* directory.

They can be pulled from: https://github.com/EOSIO/eos/tree/develop/contracts/contracts

Once example contracts' source files are included, they should be compiled when EOSIO_COMPILE_TEST_CONTRACTS is indicated.

@stephenpdeos
Copy link
Member

Agreed shared goal - all binary WASMs should be compile-able when the EOSIO_COMPILE_TEST_CONTRACTS is true. There should not be any dependency in leap to eos-system-contracts or any future reference contracts.

@stephenpdeos
Copy link
Member

Bring over minimum needed to get existing tests to pass.

@stephenpdeos
Copy link
Member

stephenpdeos commented Sep 1, 2022

Continue requirement that building with EOSIO_COMPILE_TEST_CONTRACTS is false does not create a dependency on CDT but still allows all tests to run

@heifner heifner self-assigned this Jan 2, 2023
@heifner heifner moved this from Todo to In Progress in Team Backlog Jan 2, 2023
@heifner heifner added the OCI Work exclusive to OCI team label Jan 2, 2023
heifner added a commit that referenced this issue Jan 3, 2023
heifner added a commit that referenced this issue Jan 3, 2023
heifner added a commit that referenced this issue Jan 3, 2023
heifner added a commit that referenced this issue Jan 4, 2023
…ove dependency of libraries/testing on unittests.
heifner added a commit that referenced this issue Jan 4, 2023
heifner added a commit that referenced this issue Jan 4, 2023
heifner added a commit that referenced this issue Jan 4, 2023
heifner added a commit that referenced this issue Jan 4, 2023
…its protocol feature has not been activated.
heifner added a commit that referenced this issue Jan 4, 2023
…ate contract code for eosio.bios and eosio.token to match as close as possible what matches the existing abi/wasm.
heifner added a commit that referenced this issue Jan 4, 2023
heifner added a commit that referenced this issue Jan 4, 2023
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Jan 5, 2023
heifner added a commit that referenced this issue Jan 12, 2023
…ove back into ./unittests/contracts and ./libraries/testing/CMakeLists.txt can go back to eosio_testing_contracts being INTERFACE only.
heifner added a commit that referenced this issue Jan 13, 2023
… the bios contract used in eos-system-contracts avoiding a duplicate trx error on set_code of its bios contract.
heifner added a commit that referenced this issue Jan 26, 2023
Add test contract code for existing abi/wasm and clean up libraries/testing & unittests dependencies
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Jan 26, 2023
heifner added a commit that referenced this issue Apr 29, 2024
IF: Add the beginning of a savanna disaster recovery test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Archived in project
3 participants