Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keosd http-max-response-time-ms setting #230

Closed
heifner opened this issue Sep 26, 2022 · 0 comments · Fixed by #556
Closed

keosd http-max-response-time-ms setting #230

heifner opened this issue Sep 26, 2022 · 0 comments · Fixed by #556
Assignees
@heifner
Labels
actionable enhancement New feature or request 👍 lgtm OCI Work exclusive to OCI team

Comments

@heifner
Copy link
Member

heifner commented Sep 26, 2022

Users often hit the default 30ms issue with timeouts when using keosd due to the default http-max-response-time-ms 30ms. Setting contracts or ABI can often take longer than 30ms to parse in keosd. This error is confusing to users and often hard to track down what is going wrong. Also keosd is meant to only be run locally and not provided as a service.

Consider making http-max-response-time-ms unlimited for keosd.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Sep 26, 2022
This was referenced Sep 28, 2022
Merged
Merged
@heifner heifner added enhancement New feature or request actionable and removed triage labels Oct 18, 2022
@heifner heifner self-assigned this Dec 8, 2022
@heifner heifner added the OCI Work exclusive to OCI team label Dec 8, 2022
heifner added a commit that referenced this issue Dec 8, 2022
@heifner
GH-230 cleanup exception handling
2b11608
heifner added a commit that referenced this issue Dec 8, 2022
@heifner
GH-230 Use very large deadline for keosd http response time
b063ddc
@heifner heifner mentioned this issue Dec 8, 2022
Merged
@heifner heifner moved this from Todo to In Progress in Team Backlog Dec 8, 2022
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Dec 8, 2022
heifner added a commit that referenced this issue Dec 9, 2022
@heifner
Merge pull request #556 from AntelopeIO/GH-230-max-response-time
0602269 
Set keosd max http response time to unlimited
Repository owner moved this from Awaiting Review to Done in Team Backlog Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
actionable enhancement New feature or request 👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set keosd max http response time to unlimited AntelopeIO/leap
2 participants
@heifner @enf-ci-bot