Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Use merkle calculation for transaction_mroot and action_mroot that does not use bitflip implementation #1942

Closed
Tracked by #1508
heifner opened this issue Nov 30, 2023 · 0 comments · Fixed by #1955
Closed
Tracked by #1508

IF: Use merkle calculation for transaction_mroot and action_mroot that does not use bitflip implementation #1942

heifner opened this issue Nov 30, 2023 · 0 comments · Fixed by #1955
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team

Comments

@heifner
Copy link
Member

heifner commented Nov 30, 2023 •
edited
Loading

  • Switch to new implementation on hotstuff activation not on instant finality protocol feature activation.
@heifner heifner mentioned this issue Nov 30, 2023
Closed
@arhag arhag added 👍 lgtm and removed triage labels Nov 30, 2023
@heifner heifner self-assigned this Dec 5, 2023
@heifner heifner added the OCI Work exclusive to OCI team label Dec 5, 2023
@heifner heifner moved this from Todo to In Progress in Team Backlog Dec 5, 2023
heifner added a commit that referenced this issue Dec 5, 2023
@heifner
GH-1942 Add calculate_merkle that does not use left/right bit flip im…
8f2e525 
…plementation
heifner added a commit that referenced this issue Dec 5, 2023
@heifner
GH-1942 Use calculate_merkle instead of canonical_merkle after hotstu…
7399ec8 
…ff activated
@heifner heifner mentioned this issue Dec 6, 2023
Merged
@heifner heifner linked a pull request Dec 6, 2023 that will close this issue
IF: merkle calculation for transaction_mroot and action_mroot #1955
Merged
heifner added a commit that referenced this issue Dec 6, 2023
@heifner
GH-1942 consolidate code
45741a2
heifner added a commit that referenced this issue Dec 6, 2023
@heifner
Merge pull request #1955 from AntelopeIO/GH-1942-merkle
35af4a1 
IF: merkle calculation for transaction_mroot and action_mroot
@heifner heifner closed this as completed Dec 6, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IF: merkle calculation for transaction_mroot and action_mroot AntelopeIO/leap
3 participants
@heifner @arhag @enf-ci-bot