Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

192 compile warnings in fc/secp256k1 #19

Closed
linh2931 opened this issue Aug 18, 2022 · 2 comments · Fixed by #253
Closed

192 compile warnings in fc/secp256k1 #19

linh2931 opened this issue Aug 18, 2022 · 2 comments · Fixed by #253
Assignees

Comments

@linh2931
Copy link
Member

fc/secp256k1 has 192 compile warnings. They are in the form of

libraries/fc/secp256k1/secp256k1/src/field.h:44:13: warning: ‘secp256k1_fe_normalize’ declared ‘static’ but never defined [-Wunused-function]
libraries/fc/secp256k1/secp256k1/src/field.h:47:13: warning: ‘secp256k1_fe_normalize_weak’ declared ‘static’ but never defined [-Wunused-function]
...
libraries/fc/secp256k1/secp256k1/src/ecmult_impl.h:395:12: warning: ‘secp256k1_ecmult_strauss_batch_single’ defined but not used [-Wunused-function]

They should be cleaned up after the decision of de-submoduling is made.

@spoonincode
Copy link
Member

I don't think we've considered desubmoduling this library since we use it verbatim without any modifications.

But the good thing is, we completely control compilation of this library since we use our own CMakeLists.txt (https://github.com/AntelopeIO/fc/blob/main/secp256k1/CMakeLists.txt), so it's trivial to add a -Wnounused-function option here and/or consider these SYSTEM headers.

@stephenpdeos
Copy link
Member

Blocked by Desubmodularize fc#122

@linh2931 linh2931 self-assigned this Sep 28, 2022
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Sep 28, 2022
Repository owner moved this from In Progress to Done in Team Backlog Sep 28, 2022
heifner pushed a commit that referenced this issue Apr 29, 2024
IF: Implement finalizer policy change at appropriate time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants