Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update handling of http-max-response-time-ms & abi-serializer-max-time-ms #1062

Closed
heifner opened this issue Apr 20, 2023 · 0 comments · Fixed by #1139
Closed

Update handling of http-max-response-time-ms & abi-serializer-max-time-ms #1062

heifner opened this issue Apr 20, 2023 · 0 comments · Fixed by #1139
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Leap v5.0.0-rc1

Comments

@heifner
Copy link
Member

heifner commented Apr 20, 2023 •
edited by greg7mdp
Loading

Proposal https://hackmd.io/@EOSNF/HyFXmJL73

Relevant comments:
#677 (comment)
#679 (comment)
#723 (comment)
#679 (comment)
#608 (comment)
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Apr 20, 2023
@heifner heifner mentioned this issue Apr 20, 2023
Merged
@heifner heifner added discussion and removed triage labels Apr 20, 2023
@greg7mdp greg7mdp self-assigned this Apr 26, 2023
@greg7mdp greg7mdp assigned greg7mdp and unassigned greg7mdp Apr 26, 2023
@heifner heifner self-assigned this May 1, 2023
@heifner heifner added OCI Work exclusive to OCI team and removed discussion labels May 1, 2023
@heifner heifner added this to the Leap v5.0.0-rc1 milestone May 1, 2023
@heifner heifner moved this from Todo to In Progress in Team Backlog May 1, 2023
heifner added a commit that referenced this issue May 3, 2023
@heifner
GH-1062 Remove time_point implicit conversions
18190c1
@heifner heifner mentioned this issue May 3, 2023
Merged
heifner added a commit that referenced this issue May 3, 2023
@heifner
GH-1062 Remove possibly confusing arithmetic operators for time_point…
6b10d80 
…_sec. Remove implicit conversion from time_point to time_point_sec via operator=.
heifner added a commit that referenced this issue May 3, 2023
@heifner
GH-1062 Rename time_point to_string to to_iso_string
1f60ff9
heifner added a commit that referenced this issue May 4, 2023
@heifner
Merge pull request #1125 from AntelopeIO/GH-1062-time-cleanup
a361138 
Remove time_point implicit conversions
heifner added a commit that referenced this issue May 5, 2023
@heifner
GH-1062 Remove deadline from trace_api_plugin
bbeafe9
heifner added a commit that referenced this issue May 5, 2023
@heifner
GH-1062 Remove unused struct
4692fd8
heifner added a commit that referenced this issue May 5, 2023
@heifner
GH-1062 Enforce http_max_response_time on main thread only and always…
2eb261c 
… return at least one.
heifner added a commit that referenced this issue May 5, 2023
@heifner
GH-1062 Use maximum() instead of 365 days for max
6c831db
heifner added a commit that referenced this issue May 5, 2023
@heifner
GH-1062 Add 1000 limit
8cb572c
heifner added a commit that referenced this issue May 5, 2023
@heifner
Merge remote-tracking branch 'origin/main' into GH-1062-time-limits
da28bc9
heifner added a commit that referenced this issue May 5, 2023
@heifner
GH-1062 Add move constructor for variant_object to mutable_variant_ob…
9bcbb44 
…ject
heifner added a commit that referenced this issue May 5, 2023
@heifner
GH-1062 Change default abi_serializer yield function to enforce max_s…
4e176a1 
…erialization_time per serialization step.
heifner added a commit that referenced this issue May 5, 2023
@heifner
GH-1062 Add a safe_add that does not overflow.
086f1fb
heifner added a commit that referenced this issue May 5, 2023
@heifner
GH-1062 Remove deadline since we no longer want to interrupt json cre…
0e8739e 
…ation on the http thread
heifner added a commit that referenced this issue May 5, 2023
@heifner
GH-1062 Remove deadline since we no longer want to interrupt json cre…
cb1b52d 
…ation on the http thread
heifner added a commit that referenced this issue May 5, 2023
@heifner
GH-1062 mutable_variant_object constructor for variant_object now exp…
d480a26 
…licit
heifner added a commit that referenced this issue May 5, 2023
@heifner
GH-1062 Enforce processing on the main thread to http-max-response-ti…
7e2bd04 
…me up to a max of 1000 items or http-max-response-time is -1.
@heifner heifner mentioned this issue May 5, 2023
Merged
heifner added a commit that referenced this issue May 6, 2023
@heifner
GH-1062 Avoid unneeded copies
a7c5d3c
heifner added a commit that referenced this issue May 8, 2023
@heifner
GH-1062 Fix issue with variant internal variant_object being shared
0966651
heifner added a commit that referenced this issue May 8, 2023
@heifner
GH-1062 Need to copy yield function since it is a const&
05ff752
heifner added a commit that referenced this issue May 8, 2023
@heifner
GH-1062 Only reset deadline when explicitly asked to do so.
0ef8b09
heifner added a commit that referenced this issue May 8, 2023
@heifner
GH-1062 small optimization
0eec87e
heifner added a commit that referenced this issue May 10, 2023
@heifner
GH-1062 Add variant_object to the exclude list of universal reference…
1d33a68 
… constructor of mutable_variant_object since there is an explicit constructor for it.
heifner added a commit that referenced this issue May 10, 2023
@heifner
GH-1062 Also guard against underflow
724be07
heifner added a commit that referenced this issue May 10, 2023
@heifner
GH-1062 Refactor abi_serializer to accept a max_action_data_serializa…
6096c0b 
…tion_time which applies only to action data deserialization
heifner added a commit that referenced this issue May 10, 2023
@heifner
GH-1062 Revert unneeded changes to yield call
e666cd0
heifner added a commit that referenced this issue May 10, 2023
@heifner
GH-1062 Use new fc time_point::safe_add
99f9320
heifner added a commit that referenced this issue May 12, 2023
@heifner
GH-1062 Refactor start_action_serialization into constructor of context
c7bf139
heifner added a commit that referenced this issue May 12, 2023
@heifner
GH-1062 Simplify recursion_depth lambda
af766dc
heifner added a commit that referenced this issue May 13, 2023
@heifner
GH-1062 assert on exclusive ownership of variant_object
07d5a74
heifner added a commit that referenced this issue May 15, 2023
@heifner
Merge remote-tracking branch 'origin/main' into GH-1062-time-limits
079c650
heifner added a commit that referenced this issue May 15, 2023
@heifner
GH-1062 Fix merge issues
8ade327
heifner added a commit that referenced this issue May 15, 2023
@heifner
GH-1062 Add back check for correct table
6d0a06b
heifner added a commit that referenced this issue May 15, 2023
@heifner
GH-1062 Simplify deadline calculation.
87e598a
heifner added a commit that referenced this issue May 15, 2023
@heifner
GH-1062 Make get_activated_protocol_features atomic
3dc1841
heifner added a commit that referenced this issue May 15, 2023
@heifner
GH-1062 Update test to reflect get_activate_protocol_features ignored…
2df7459 
… limit and time limit
heifner added a commit that referenced this issue May 15, 2023
@heifner
GH-1062 Change default http-max-response-time-ms from 30 to 15
bd896c7
heifner added a commit that referenced this issue May 15, 2023
@heifner
GH-1062 If time_limit_ms not specified use http-max-response-time-ms …
0465384 
…instead of 10ms
heifner added a commit that referenced this issue May 16, 2023
@heifner
Merge pull request #1139 from AntelopeIO/GH-1062-time-limits
203309b 
Update API/serialization time constraints
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Leap v5.0.0-rc1
Development

Successfully merging a pull request may close this issue.

Update API/serialization time constraints AntelopeIO/leap
3 participants
@greg7mdp @heifner @enf-ci-bot