[leap5] only run overcommit dependent tests on Linux when overcommit is configured appropriately #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These newly added tests are only well defined on Linux when
overcommit_memoryis set to 0 or 21. Ifovercommit_memoryis set to 1, or run on platforms that have different semantics here then Linux, they will improperly fail. For example, on macOS it allows this large private mapping and then chainbase just takes eons writing out the entire 4TB (now 6TB in this PR) memory.So only run these tests on Linux, and only run them when
overcommit_memoryis 0 or 2.Footnotes
and for both configs, that total system memory is below the threshold that the test uses ↩