Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
benchmark
directory containing a benchmark designed to exercise theundo_index
specifically.I ran it 9 times with the older version of chainbase (before the memory optimization) and identically 9 times with the newer version (using 42 bit offsets as pointers for memory efficiency).
The memory optimized version does not appear to be significantly slower (test with gcc_12, release build, AMD 7950x). These numbers show an average 3.05% slowdown with the memory optimization with intensive chainbase use, so I would not expect to see a noticable slowdown in leap.