Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "extend the plugin initialization try/catch block" #19

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Revert "extend the plugin initialization try/catch block" #19

merged 1 commit into from
Apr 11, 2023

Conversation

huangminghuang
Copy link
Contributor

This reverts commit ba7f40d.

The change in ba7f40d prevents leap from returning the appropriate error number based on the exception which causes validate_dirty_db_test to fail.

@huangminghuang huangminghuang requested review from greg7mdp, heifner and linh2931 and removed request for greg7mdp and heifner April 11, 2023 17:23
linh2931
linh2931 approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@linh2931 linh2931 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have some test later.

@huangminghuang huangminghuang merged commit e2dbcc3 into main Apr 11, 2023
@huangminghuang huangminghuang deleted the huangminghuang/revert-extened-try branch April 11, 2023 18:52
@spoonincode spoonincode mentioned this pull request Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@heifner heifner heifner approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huangminghuang @greg7mdp @heifner @linh2931