Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test to reproduce the issue with missing historical references/versions ('Before', 'Regression', 'Fixed', 'Slow', 'Fast') #24

Merged
merged 7 commits into from
Oct 8, 2024
Merged

Test to reproduce the issue with missing historical references/versions ('Before', 'Regression', 'Fixed', 'Slow', 'Fast') #24

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e597f6f
Update tests.R
Anirban166 Oct 7, 2024
20fd031
Retaining the existing list (extra.test.list) without overwriting it
Anirban166 Oct 7, 2024
faad84d
Switch back to my original versions (merge commit and its parent) sin…
Anirban166 Oct 7, 2024
866e7bc
Using substitute() instead of str2lang(), avoiding T/F, index.list is…
Anirban166 Oct 7, 2024
4d1bb5a
Making the use of expr as an unevaluated language object consistent a…
Anirban166 Oct 7, 2024
5750f5d
Update tests.R
Anirban166 Oct 7, 2024
7b0b68d
Revert, sync with Rdatatable, modify SHAs
Anirban166 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion .ci/atime/tests.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,31 @@ for (extra.arg in extra.args.6107){
extra.test.list[[sprintf("fread(%s) improved in #6107", extra.arg)]] <- this.test
}

# Test case adapted from https://github.com/Rdatatable/data.table/pull/4386#issue-602528139 which is where the performance was improved.
for(retGrp_chr in c("T","F"))extra.test.list[[sprintf(
"forderv(retGrp=%s) improved in #4386", retGrp_chr
)]] <- list(
setup = quote({
dt <- data.table(group = rep(1:2, l=N))
}),
expr = substitute({
old.opt <- options(datatable.forder.auto.index = TRUE) # required for test, un-documented, comments in forder.c say it is for debugging only.
data.table:::forderv(dt, "group", retGrp = RETGRP)
options(old.opt) # so the option does not affect other tests.
}, list(RETGRP=eval(str2lang(retGrp_chr)))),
## From ?bench::mark, "Each expression will always run at least twice,
## once to measure the memory allocation and store results
## and one or more times to measure timing."
## So for atime(times=10) that means 11 times total.
## First time for memory allocation measurement,
## (also sets the index of dt in this example),
## then 10 more times for time measurement.
## Timings should be constant if the cached index is used (Fast),
## and (log-)linear if the index is re-computed (Slow).
Slow = "c152ced0e5799acee1589910c69c1a2c6586b95d", # Parent of merge commit
Fast = "1a84514f6d20ff1f9cc614ea9b92ccdee5541506" # Merge commit SHA
)

# A list of performance tests.
#
# See documentation in https://github.com/Rdatatable/data.table/wiki/Performance-testing for best practices.
Expand Down Expand Up @@ -207,6 +232,6 @@ test.list <- atime::atime_test_list(
expr = data.table:::melt(DT, measure.vars = measure.vars),
Slow = "fd24a3105953f7785ea7414678ed8e04524e6955", # Parent of the merge commit (https://github.com/Rdatatable/data.table/commit/ed72e398df76a0fcfd134a4ad92356690e4210ea) of the PR (https://github.com/Rdatatable/data.table/pull/5054) that fixes the issue
Fast = "ed72e398df76a0fcfd134a4ad92356690e4210ea"), # Merge commit of the PR (https://github.com/Rdatatable/data.table/pull/5054) that fixes the issue

tests=extra.test.list)
# nolint end: undesirable_operator_linter.