Skip to content

Commit

Permalink
JIT: disable phi based redundant branch opts
Browse files Browse the repository at this point in the history
This is exposing our lack of SSA update and leading downstream opts like CSE
and assertion prop to make bad decisions.

Disabling for now until I have time to figure out how to safely enable.

Fixes dotnet#76636, dotnet#76507
  • Loading branch information
AndyAyersMS committed Oct 6, 2022
1 parent 144a33a commit 5750b55
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/coreclr/jit/redundantbranchopts.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,12 @@ bool Compiler::optRedundantBranch(BasicBlock* const block)
// We were unable to determine the relop value via dominance checks.
// See if we can jump thread via phi disambiguation.
//
return optJumpThreadPhi(block, tree, treeNormVN);
// optJumpThreadPhi disabled as it is exposing problems with stale SSA.
// See issue #76636 and related.
//
// return optJumpThreadPhi(block, tree, treeNormVN);

return false;
}

// Be conservative if there is an exception effect and we're in an EH region
Expand Down

0 comments on commit 5750b55

Please sign in to comment.