-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework solution api #71
Rework solution api #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if the unable_to_run
and get_result
functions are particularly useful as they can only ever be called from one place but it's whatever. The behavior change in --timeout
needs fixing though.
The purpose was more to make each function easier to skim + group and document what those lines of code were doing.
Done, sorry about that. |
run
function tolazy_run
lazy_run
App
may need to be in the library and that these tests cannot run in CI because they depend on the clash dir, which inspired Test "framework" #72SuiteRun
and replaced it with a call tomap()
🤦App.run
slightlyRegarding
App
I suggest
App
to libApp
App
and just having them as regular functions inmain.rs
(or as part of aCli
type)App
constructor to take a singlepackage_name
parameter:This would then separate the responsibility between calling the commands and the helper functions which we could use in tests. It would also prepare for #61 by allowing configuration to be stored in
App
and be used by users of the lib.