Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for NO_COLOR #58

Merged
merged 3 commits into from
Apr 25, 2024
Merged

add support for NO_COLOR #58

merged 3 commits into from
Apr 25, 2024

Conversation

Andriamanitra
Copy link
Owner

closes #45

@daxida
Copy link
Collaborator

daxida commented Apr 23, 2024

Seems to work fine. I would suggest to at least add a line of documentation to the README since at the moment there is no way to know about this interaction through the CLI error / help messages.

daxida
daxida approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@daxida daxida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it in ubuntu and this also works fine: NO_COLOR=1 cargo run show

No idea how that will fare for windows/iOS.

@Andriamanitra Andriamanitra merged commit f48b232 into main Apr 25, 2024
2 checks passed
@Andriamanitra Andriamanitra deleted the nocolor-support branch April 25, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxida daxida daxida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support NO_COLOR environment variable
2 participants
@Andriamanitra @daxida