Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wandb 0.19.1 ❄️ #4

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

wandb 0.19.1 ❄️ #4

wants to merge 5 commits into from

Conversation

solesnake
Copy link

@solesnake solesnake commented Jan 17, 2025

wandb 0.19.1 ❄️

Destination channel: Snowflake

Links

Explanation of changes:

  • new version number

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_79zf1xofuu/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:32: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:30: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:28: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:41: python_build_tool_in_run: The python build tool setuptools is in run depends
  • clone/recipe/meta.yaml:29: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.

===== ERRORS =====

  • clone/recipe/meta.yaml:30: should_use_compilers: The recipe requires a compiler directly
  • clone/recipe/meta.yaml:32: should_use_compilers: The recipe requires a compiler directly
    ===== Final Report: =====
    2 Errors and 5 Warnings were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_d1wsgf_67g/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:32: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:41: python_build_tool_in_run: The python build tool setuptools is in run depends
  • clone/recipe/meta.yaml:30: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:29: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:28: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.

===== ERRORS =====

  • clone/recipe/meta.yaml:30: should_use_compilers: The recipe requires a compiler directly
  • clone/recipe/meta.yaml:32: compilers_must_be_in_build: The recipe requests a compiler in a section other than build
    ===== Final Report: =====
    2 Errors and 5 Warnings were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_62qa9e17wd/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:36: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:38: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:47: python_build_tool_in_run: The python build tool setuptools is in run depends
    ===== Final Report: =====
    0 Errors and 3 Warnings were found

@solesnake solesnake closed this Jan 28, 2025
@solesnake solesnake reopened this Jan 28, 2025
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_09stsksd84/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:38: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:36: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:47: python_build_tool_in_run: The python build tool setuptools is in run depends
    ===== Final Report: =====
    0 Errors and 3 Warnings were found

@solesnake solesnake marked this pull request as ready for review January 28, 2025 15:01
- typing-extensions >=4.4,<5 # [py<312]
- platformdirs
- pydantic >=2.6,<3
- eval-type-backport # [py<310]

test:
imports:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no such folder in PyPI archive. May switch to GitHub though.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, you need to switch.

@Andrii-Osipov
Copy link

url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/wandb-{{ version }}.tar.gz
sha256: 2c39e129fb8dc69c7ff813aa52c2ce7f98e3a0f25c12dd96b1de7528d9443a84
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
sha256: a9b4bf790c468e7b350eeaba2de002672a5cbaa3049899ab060940e2388f429a

build:
number: 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But what is the main reason to remove s390x?

@Andrii-Osipov
Copy link

Enable py313 in abs.yaml

build_env_vars:
  ANACONDA_ROCKET_ENABLE_PY313 : yes

- setuptools

- typing-extensions 4.7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- typing-extensions 4.7
- typing-extensions

You can drop pinnings for Python packages in host, see the recipe standards https://github.com/anaconda-distribution/perseverance-skills/blob/main/sections/02_Package_building/02_Recipes/Recipe_standards.md#the-requirements-section
It will simplify future Python build-outs

run:
- click >=7.1,!=8.0.0
- docker-pycreds >=0.4.0
- gitpython >=1.0.0,!=3.1.29
- pathtools
- protobuf >=3.20.3,!=4.21.0,<5
- protobuf >=3.12.0,!=4.21.0,!=5.28.0,<6

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- protobuf >=3.12.0,!=4.21.0,!=5.28.0,<6
- protobuf >=3.19.0,!=4.21.0,!=5.28.0,<6

Because we do not support py<39, see https://github.com/wandb/wandb/blob/v0.19.1/pyproject.toml#L26-L27

@@ -21,26 +21,36 @@ build:
script: {{ PYTHON }} -m pip install . --no-deps --ignore-installed --no-cache-dir --no-build-isolation -vvv

requirements:
build:
# we use go directly because we do not have activation feedstocks
# therefore we can't use compiler('go') and we skip linting
Copy link

@skupr-anaconda skupr-anaconda Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't it work with compiler('go-cgo')? Asking, because our cbc.yaml provides the version we support https://github.com/AnacondaRecipes/aggregate/blob/master/conda_build_config.yaml#L102-L117.

The conda-forge recipe has these compilers and build-time dependencies:

    - {{ compiler('c') }}
    - {{ compiler('go-cgo') }}
    - {{ compiler('rust') }}
    - cargo-bundle-licenses
    - go-licenses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants