Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torchvision 0.11.3 #4

Merged
merged 21 commits into from
Aug 30, 2022
Merged

torchvision 0.11.3 #4

merged 21 commits into from
Aug 30, 2022

Conversation

skupr-anaconda
Copy link

@skupr-anaconda skupr-anaconda commented Aug 22, 2022

Changelog: https://github.com/pytorch/vision/releases
License: https://github.com/pytorch/vision/blob/v0.11.3/LICENSE
Requirements:

Actions:

  1. Update cbc.yaml
  2. Add 0001-avoid-hard-coded-gcc.patch
  3. Skip py<36 or py>39 or s390x or ppc64le
  4. Update scripts for win and not win
  5. Update missing_dso_whitelist for win
  6. Add dependencies to build
  7. Update dependencies and pinnings in host and run
  8. Add pip and setuptools in test/requires
  9. Add pip check
  10. Update test/commands: skip some tests
  11. Fix home and doc urls with HTTPS
  12. Fix license name

@skupr-anaconda skupr-anaconda self-assigned this Aug 22, 2022
@skupr-anaconda skupr-anaconda requested a review from mcg1969 August 23, 2022 08:09
@skupr-anaconda
Copy link
Author

I've just tested it from c3i_test2 by using this example https://blog.jovian.ai/intro-to-computer-vision-with-pytorchs-torchvision-46c4ff43ce34
It works on win64.

@varlackc varlackc self-requested a review August 23, 2022 14:55
Copy link

@varlackc varlackc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be an issue with the doc_url
https://pytorch.org/docs/master/torchvision

The following url seems to be a better alternative:
https://pytorch.org/docs/stable/index.html

Copy link

@pseudoyim pseudoyim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments about the cbc.yaml and adding comments in the meta.yaml. Thank you!

@skupr-anaconda
Copy link
Author

There seem to be an issue with the doc_url https://pytorch.org/docs/master/torchvision

The following url seems to be a better alternative: https://pytorch.org/docs/stable/index.html

Thanks, Maxwell. I've updated the doc url

Copy link

@pseudoyim pseudoyim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@varlackc varlackc self-requested a review August 29, 2022 17:47
Copy link

@varlackc varlackc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skupr-anaconda skupr-anaconda merged commit 58639c6 into master Aug 30, 2022
@skupr-anaconda skupr-anaconda deleted the v0.11.3 branch August 30, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants