Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntbtls 0.3.2 ❄️ #1

Merged
merged 13 commits into from
Jan 21, 2025
Merged

ntbtls 0.3.2 ❄️ #1

merged 13 commits into from
Jan 21, 2025

Conversation

msentissi
Copy link

@msentissi msentissi commented Jan 15, 2025

ntbtls 0.3.2 ❄️

Destination channel: Snowflake

Links

Explanation of changes:

  • Removed unnecessary dependencies

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_17j0o2zk72/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:23: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:24: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.

===== ERRORS =====

  • clone/recipe/meta.yaml:0: missing_tests: No tests were found.
    ===== Final Report: =====
    1 Error and 2 Warnings were found

@msentissi msentissi marked this pull request as ready for review January 15, 2025 19:25
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_db5lor0g2r/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:24: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:23: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
    ===== Final Report: =====
    0 Errors and 2 Warnings were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_81jndgj531/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:24: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:25: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
    ===== Final Report: =====
    0 Errors and 2 Warnings were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_ad32_xo90z/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:24: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:25: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
    ===== Final Report: =====
    0 Errors and 2 Warnings were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_253nbowrfk/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:24: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:25: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:27: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
    ===== Final Report: =====
    0 Errors and 3 Warnings were found

Copy link

@psteyer psteyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psteyer
Copy link

psteyer commented Jan 15, 2025

Was there ever a decision on if we should leave CI files from CF? I'm a bit unsure.

recipe/meta.yaml Outdated Show resolved Hide resolved
Copy link

@ifitchet ifitchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit about the license. (Can't be a nit if it involves lawyers...)

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_3fy6rvpzzh/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:24: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:27: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:25: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
    ===== Final Report: =====
    0 Errors and 3 Warnings were found

@msentissi
Copy link
Author

Was there ever a decision on if we should leave CI files from CF? I'm a bit unsure.

We discussed the pros and cons but didn't arrive at a definitive conclusion. I remain unconvinced that it's a good idea to keep those files in.

recipe/meta.yaml Outdated Show resolved Hide resolved
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_cbv4uss5h8/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:25: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:24: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:27: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
    ===== Final Report: =====
    0 Errors and 3 Warnings were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_d0ha7ho91r/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:25: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:24: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:27: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
    ===== Final Report: =====
    0 Errors and 3 Warnings were found

@ifitchet
Copy link

I remain unconvinced that it's a good idea to keep those files in.

That was yesterday... 😆

@msentissi
Copy link
Author

I remain unconvinced that it's a good idea to keep those files in.

That was yesterday... 😆

@psteyer It seems that removing the files makes re-syncing with CF painful enough to justify keeping them in. I reversed the removal of files in all of the tickets I'm working on atm, and will stop removing them in the future.

@msentissi msentissi merged commit 5c17cea into main Jan 21, 2025
8 checks passed
@msentissi msentissi deleted the PKG-6748_ntbtls_0.3.2 branch January 21, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants