Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up feature branch deploys #663

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Set up feature branch deploys #663

merged 5 commits into from
Oct 23, 2023

Conversation

alimpens
Copy link
Contributor

No description provided.

@github-actions github-actions bot temporarily deployed to staging-feature-DES-192-setup-feature-branch-deploys October 20, 2023 09:31 Destroyed
dlnr
dlnr previously approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@dlnr dlnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe just a heads up for branching in the repo. Is it only for maintainers or can anyone branch?

@alimpens
Copy link
Contributor Author

LGTM. Maybe just a heads up for branching in the repo. Is it only for maintainers or can anyone branch?

Anyone can branch, I think it would be too much of a bottleneck if only maintainers could create branches.

@github-actions github-actions bot temporarily deployed to staging-feature-DES-192-setup-feature-branch-deploys October 23, 2023 10:21 Destroyed
VincentSmedinga
VincentSmedinga approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to help us so much! ✨

@VincentSmedinga VincentSmedinga changed the title Setup feature branch deploys Set up feature branch deploys Oct 23, 2023
@VincentSmedinga VincentSmedinga merged commit 96bd101 into main Oct 23, 2023
@alimpens alimpens deleted the feature/DES-192-setup-feature-branch-deploys branch December 8, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentSmedinga VincentSmedinga VincentSmedinga approved these changes

@dlnr dlnr dlnr left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alimpens @VincentSmedinga @dlnr