Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Merge decorators #1747

Merged
merged 4 commits into from
Nov 11, 2024
Merged

chore: Merge decorators #1747

merged 4 commits into from
Nov 11, 2024

Conversation

VincentSmedinga
Copy link
Contributor

Merging the colour decorators with the global one hides their resulting markup from the HTML element, which may confuse users.

Switching the order of the class selectors prevents invalid appearances of components for which both the contrastColor and inverseColor have been set to true.

This prevents its rendered markup from appearing in the HTML tab of Storybook, which may confuse users.
@github-actions github-actions bot temporarily deployed to demo-merge-color-decorators November 8, 2024 17:44 Destroyed
@alimpens alimpens merged commit e5725a7 into develop Nov 11, 2024
6 checks passed
@alimpens alimpens deleted the chore/merge-color-decorators branch November 11, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants