-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Wrap all stories in a Screen #1728
Merged
VincentSmedinga
merged 11 commits into
develop
from
feature/DES-974-storybook-screen-decorator
Nov 8, 2024
Merged
chore: Wrap all stories in a Screen #1728
VincentSmedinga
merged 11 commits into
develop
from
feature/DES-974-storybook-screen-decorator
Nov 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-DES-974-storybook-screen-decorator
October 29, 2024 11:14
Destroyed
VincentSmedinga
commented
Oct 29, 2024
dlnr
reviewed
Oct 29, 2024
alimpens
reviewed
Nov 4, 2024
# Conflicts: # storybook/src/components/Breakout/Breakout.stories.tsx
github-actions
bot
temporarily deployed
to
demo-DES-974-storybook-screen-decorator
November 8, 2024 13:57
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-974-storybook-screen-decorator
November 8, 2024 14:04
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-974-storybook-screen-decorator
November 8, 2024 14:12
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-974-storybook-screen-decorator
November 8, 2024 14:16
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-974-storybook-screen-decorator
November 8, 2024 14:24
Destroyed
alimpens
approved these changes
Nov 8, 2024
VincentSmedinga
deleted the
feature/DES-974-storybook-screen-decorator
branch
November 8, 2024 15:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What
This wraps all stories of Storybook in a
Screen
component.I’ve not made an exception for our page examples to keep the Skip Link spanning the entire page width. I think it’s best to limit that link to the Screen's width to prevent it from growing overly large on very wide screens. This doesn’t change its functionality. Few screens will be affected in practice.
Why
To ensure no example is wider than a
Screen
, which should not happen as we demand every page to be wrapped in such a component.We could override the decorator for application screens later, but there’s no need now.
How
div lang="nl"
that wrapped all stories, keeping the language attributeChecklist
Additional notes
–