Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Wrap all stories in a Screen #1728

Merged
merged 11 commits into from
Nov 8, 2024

Conversation

VincentSmedinga
Copy link
Contributor

Describe the pull request

What

This wraps all stories of Storybook in a Screen component.

I’ve not made an exception for our page examples to keep the Skip Link spanning the entire page width. I think it’s best to limit that link to the Screen's width to prevent it from growing overly large on very wide screens. This doesn’t change its functionality. Few screens will be affected in practice.

Why

To ensure no example is wider than a Screen, which should not happen as we demand every page to be wrapped in such a component.

We could override the decorator for application screens later, but there’s no need now.

How

  • Replaced the div lang="nl" that wrapped all stories, keeping the language attribute
  • Removed decorators wrapping a Screen for component stories

Checklist

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix

Additional notes

@github-actions github-actions bot temporarily deployed to demo-DES-974-storybook-screen-decorator October 29, 2024 11:14 Destroyed
storybook/config/preview.tsx Show resolved Hide resolved
storybook/src/components/SkipLink/SkipLink.stories.tsx Outdated Show resolved Hide resolved
storybook/config/preview.tsx Show resolved Hide resolved
storybook/config/preview.tsx Show resolved Hide resolved
storybook/config/preview.tsx Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-974-storybook-screen-decorator November 8, 2024 13:57 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-974-storybook-screen-decorator November 8, 2024 14:04 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-974-storybook-screen-decorator November 8, 2024 14:12 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-974-storybook-screen-decorator November 8, 2024 14:16 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-974-storybook-screen-decorator November 8, 2024 14:24 Destroyed
@VincentSmedinga VincentSmedinga merged commit 121b9de into develop Nov 8, 2024
6 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/DES-974-storybook-screen-decorator branch November 8, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants