Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: File input with preview #1699

Closed
wants to merge 13 commits into from
Closed

feat: File input with preview #1699

wants to merge 13 commits into from

Conversation

dlnr
Copy link
Contributor

@dlnr dlnr commented Oct 25, 2024

Describe the pull request

PoC for File input that displays a file preview list. Based on the MDN example and using the FileList interface. This is a logical enrichment of the native file input that allows you to show file previews or a document icon.

What

This would need cleanup if this is something we want.

Why

The designs often ask for such a component, allthough it would be hard to display an upload progress bar (maybe on submit) it looks a lot like the original idea.

It uses a label for a drop (or click) zone to allow for custom text where the native upload button displays browser/language specific text.

How

Only if you use the boolean showFiles and if you want a list f files you also need the multiple attribute.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • Provide links to any related issues or discussions.
  • Add a link to the specific story in the feature branch deploy.
  • Mention any areas where additional review or feedback is needed.

@github-actions github-actions bot temporarily deployed to demo-file-uploader-poc October 25, 2024 09:50 Destroyed
@github-actions github-actions bot temporarily deployed to demo-file-uploader-poc October 25, 2024 09:53 Destroyed
@github-actions github-actions bot temporarily deployed to demo-file-uploader-poc October 28, 2024 12:38 Destroyed
@github-actions github-actions bot temporarily deployed to demo-file-uploader-poc October 28, 2024 14:29 Destroyed
@github-actions github-actions bot temporarily deployed to demo-file-uploader-poc October 31, 2024 15:05 Destroyed
@github-actions github-actions bot temporarily deployed to demo-file-uploader-poc October 31, 2024 15:16 Destroyed
@github-actions github-actions bot temporarily deployed to demo-file-uploader-poc October 31, 2024 15:18 Destroyed
@github-actions github-actions bot temporarily deployed to demo-file-uploader-poc November 1, 2024 10:00 Destroyed
@github-actions github-actions bot temporarily deployed to demo-file-uploader-poc November 1, 2024 10:04 Destroyed
@dlnr dlnr closed this Nov 8, 2024
@dlnr
Copy link
Contributor Author

dlnr commented Nov 8, 2024

Close PR after discussion, we'll split the file list to a separate component and add javascript listener as a code example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant