Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct various issues from old TeX extraction #13

Merged
merged 16 commits into from
May 11, 2021
Merged

fix: correct various issues from old TeX extraction #13

merged 16 commits into from
May 11, 2021

Conversation

pkra
Copy link
Member

@pkra pkra commented Apr 26, 2021

Fixes several issues due to incompatibilities between xetex+unicode-math and MathJax+mathjax-unicode-math.

Closes #11

WARNING includes new issues, see
#11 (comment)
WARNING squash before merge!
@pkra
Copy link
Member Author

pkra commented May 4, 2021

Rebased on master.

pkra added 9 commits May 4, 2021 13:35
This definition would break stretchy root overlines.

Part of #11
Document this intentional change (which is an improvement).

See also the discussion in #11.
Avoids nabla becoming italic by falling back to core MathJax.
Avoids problems in superscripts by falling back to core MathJax.

Part of #11
Set emptyset to use u2205's variant form (cf varnothing).
NOTE This is STIX Two specific; CM has u2205 forms reversed.

Part of #11
Disables many to fallback to core MathJax, and adjusts others.
The main theme is to avoid combining above/below characters.

Part of #11
@pkra pkra changed the title WIP issue 11 fix: correct various issues from old TeX extraction May 4, 2021
@pkra
Copy link
Member Author

pkra commented May 4, 2021

@davidmjones this is ready for review (the html files with -output might be useful)

@pkra pkra requested a review from davidmjones May 4, 2021 19:43
@pkra
Copy link
Member Author

pkra commented May 6, 2021

Updated with recent STIX2 fixes. Now with good looking accents -- thanks @dpvc!

@pkra
Copy link
Member Author

pkra commented May 6, 2021

(The only one that didn't change was U+20D2 but I don't know what it's supposed to look like).

@pkra
Copy link
Member Author

pkra commented May 6, 2021

Visual regression tests for our v3 sample set came back clean.

@dpvc
Copy link

dpvc commented May 6, 2021

(The only one that didn't change was U+20D2 but I don't know what it's supposed to look like).

U+20D2 is COMBINING LONG VERTICAL LINE OVERLAY, so not an accent (just a regular combining character that should overstrike the U+0338 \not symbol), so it didn't get any correction. I see that you have it listed as calling the Accent function, but I think that is not appropriate for this character.

@pkra
Copy link
Member Author

pkra commented May 7, 2021

Thanks for the pointer @dpvc. The TS was originally generated from the TeX file in the bin folder (with the scripts by @davidmjones) where it's a mathaccent, cf. also http://mirrors.ctan.org/macros/unicodetex/latex/unicode-math/unimath-symbols.pdf.

Anyway, this is the kind of thing why we're switching away from the generated TS.
I'll fix it.

@dpvc
Copy link

dpvc commented May 7, 2021

Well, I suppose it would be possible to use it as an accent if we adjusted the bounding box so that it had negative depth (like other accents), and so that when it is placed above a character, it "hangs down" below its depth. Perhaps that is how unicode-math can treat this as an accent. As I recall, TeX fonts have height and depth values that are not necessarily related to the actual ink, just as left- and right-bearing may not match the actual bounding box of the ink; for example, the height and depth of the minus sign is the same as the plus sign so that they align the same in super- and subscripts. Perhaps the TeX version of the STIX2 font has such values for this character so that is can work as an accent. We can try that out if you like. But since the position of the accent is based on the height of the character, that does mean the vertical overstrike would have different vertical positions for different letters (probably not what is desired).

@pkra
Copy link
Member Author

pkra commented May 7, 2021

I dunno. It looks like a \not kind of thing to me. @davidmjones will know best.

@pkra
Copy link
Member Author

pkra commented May 11, 2021

As per F2F, this can be merged without resolving \vertoverlay.

@pkra pkra mentioned this pull request May 11, 2021
@pkra pkra merged commit 794da78 into master May 11, 2021
@pkra pkra deleted the issue11 branch May 11, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

open list of unexpected changes
3 participants