AIP #6 impl #267
Merged
AIP #6 impl #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivshti
requested changes
Mar 27, 2020
services/sentry/lib/eventReducer.js
Outdated
| let aggr = { ...initialAggr } | ||
|
|
||
| const ev = { ...event, ...session } // add session details (i.e country, device type etc) to event |
There was a problem hiding this comment.
why don't you just pass the session to getPayout
There was a problem hiding this comment.
i have changed it to pass session
Ivshti
requested changes
Mar 31, 2020
| @@ -114,12 +114,23 @@ module.exports = { | |||
| .keys() | |||
| .pattern( | |||
| /^(IMPRESSION|CLICK)$/, | |||
| Joi.object({ min: numericString.default('0'), max: numericString.default('0') }) | |||
| Joi.object({ min: numericString.required(), max: numericString.required() }) | |||
There was a problem hiding this comment.
why does this no longer have a default?
There was a problem hiding this comment.
This because if it has default '0', then the behavior becomes unreliable if an advertiser specifies one property and omits the next. e.g. specifies min omits max
services/sentry/lib/eventReducer.js
Outdated
| let aggr = { ...initialAggr } | ||
|
|
||
| const ev = { ...event, ...session } // add session details (i.e country, device type etc) to event |
Ivshti
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds implementation of AIP#6 to validator