-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add frame timings #1211
Add frame timings #1211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments and questions 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM outside of what Freja mentioned.
We might want to get timings for individual systems at some point int he future, but there's no particular rush. The breakdown you've done so far should be enough to get some useful information! Nice work :)
Shall we merge this? |
I'm going to update the structure a bit to make packages less coupled but that'll be after the Xmas break. As for the coupling itself.. there'll still be coupling around the reporting api (whatever the report method would it be other parts have to know how (currently |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great,
I suppose we could say it is a good timing to merge this 😛
Addresses #1121
Makes input to rendered available in the debugger.