Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/navigation main content #1843

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Fix/navigation main content #1843

merged 3 commits into from
Feb 21, 2024

Conversation

mikaelrss
Copy link
Contributor

@mikaelrss mikaelrss commented Feb 20, 2024

Description

I discovered that focus was placed on main-content when loading a specific page the first time. This is not wanted behaviour, as this skips some of the content for screen reader users.

I also removed the :focus-visible outline when focusing this element. After a long read, I am confident that we aren't breaking WCAG SC 2.4.7, because the element is not "keyboard operable".

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@mikaelrss mikaelrss changed the base branch from main to v3 February 20, 2024 15:11
@mikaelrss mikaelrss force-pushed the fix/navigation-main-content branch from f0439c8 to d90d71c Compare February 20, 2024 15:38
@mikaelrss mikaelrss force-pushed the fix/navigation-main-content branch from 49f311b to 3410eab Compare February 21, 2024 08:37
@mikaelrss mikaelrss marked this pull request as ready for review February 21, 2024 08:57
@mikaelrss mikaelrss added kind/bug Something isn't working area/accessibility related to WCAG and accessibility labels Feb 21, 2024
Copy link

@mikaelrss mikaelrss merged commit 1ef1d0e into v3 Feb 21, 2024
8 of 9 checks passed
@mikaelrss mikaelrss deleted the fix/navigation-main-content branch February 21, 2024 13:50
@olemartinorg
Copy link
Contributor

Do we need a new v3-release for this fairly soon?

@mikaelrss
Copy link
Contributor Author

Yes, I think we should do it today. I am just wondering if we also should include #1037 or if they should be separate releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/accessibility related to WCAG and accessibility kind/bug Something isn't working
Projects
Status: ✅ Done
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants