Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't b64 encode configmap data #1540

Merged

Conversation

marvinWolff
Copy link
Contributor

In this PR the Dashboards were switched from secret to configmap, but the base64 encoding wasn't removed.

Also, a little bit of formatting was needed, as otherwise the deployment would fail.


Thanks for taking the time to contribute to clickhouse-operator!

Please, read carefully instructions on how to make a Pull Request.

This will help a lot for maintainers to adopt your Pull Request.

Important items to consider before making a Pull Request

Please check items PR complies to:

  • All commits in the PR are squashed. More info
  • The PR is made into dedicated next-release branch, not into master branch1. More info
  • The PR is signed. More info

--

1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into master branch, but it has to be confirmed by project's maintainer.

Signed-off-by: Marvin Wolff <mw@teuto.net>
@Slach Slach self-requested a review October 23, 2024 18:51
@Slach Slach merged commit bd5b09c into Altinity:0.24.1 Oct 23, 2024
2 checks passed
@Slach
Copy link
Collaborator

Slach commented Oct 23, 2024

nice catch, thanks for contribution

@marvinWolff
Copy link
Contributor Author

@Slach Do you know when this is going to be released?

@Slach
Copy link
Collaborator

Slach commented Oct 30, 2024

we don't provide public ETA

@marvinWolff
Copy link
Contributor Author

marvinWolff commented Nov 26, 2024

Hello @Slach,

this is currently blocking our deployment, as we can't use the Dashboards. Could you take another look at this and maybe create a release?

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants